New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not run under node v12 #127
Comments
Any chance you would want to make a pull request for this? I no longer run a hubot on xmpp so this project is mostly in maintenance mode. |
I've done some digging. The dependency chain to the offending package is hubot-xmpp@0.2.6 -> node-xmpp-client@3.0.0 -> node-xmpp-core@4.2.0-> tls-connect@0.2.2 The change in tls-connect is trivial, but isn't the way to go here. https://www.npmjs.com/package/node-xmpp-client (currently at v3.2.0, 3 years old) says:
and https://www.npmjs.com/package/node-xmpp-core (currently v5.0.9, also 3 years old) says:
(https://www.npmjs.com/package/@xmpp/client code is https://github.com/xmppjs/xmpp.js) So I think hubot-xmpp needs updating to use this. This isn't really my area of expertise; it appears it might be relatively straightforward for someone suitably skilled but isn't something I can commit to right now. |
Author of xmpp.js here (and latest maintainer of node-xmpp). node-xmpp is not maintained anymore Normally I would send a PR here but since it is in maintanance mode it doesn't make sense. @markstory would you be willing to transfer the hubot-xmpp npm name? |
Sure. I would be happy to transfer this repository as well if you're interested. |
that'd be great to keep the history Can you transfer to https://github.com/xmppjs ? |
@sonnyp Sure. I've added you as a collaborator on this project but I don't think that will let you do the transfer. If I could be temporarily added to the xmppjs organization I could transfer the repository. |
@markstory done |
@sonnyp Thanks, I'll need 'create repository' privilege in order to do the transfer. |
@markstory granted, sorry for the delay |
@sonnyp Moved now. What username should I add to the npm package? |
Thanks, |
@gloomytrousers could you try hubot-xmpp 0.3.0 ? https://github.com/xmppjs/hubot-xmpp/releases/tag/v0.3.0 It still uses node-xmpp for now but the last version which should fix your issue. |
Seems to be running perfectly, thanks @sonnyp ! |
It fixes an issue that prevented it from running under Node 12: xmppjs/hubot-xmpp#127 Co-authored-by: Garret Alfert <alfert@wevelop.de>
Attempting to run hubot with xmpp connector under node v12, I get:
It's OK under node v10, although I get these warnings, the first of which gives the obvious reason and the fix, and the second of which should also be addressed:
The text was updated successfully, but these errors were encountered: