Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRLF conversion #28

Closed
ForNeVeR opened this issue Aug 29, 2016 · 0 comments · Fixed by #31
Closed

CRLF conversion #28

ForNeVeR opened this issue Aug 29, 2016 · 0 comments · Fixed by #31
Assignees
@ForNeVeR
Labels
kind:refactor

Comments

@ForNeVeR
Copy link
Member

ForNeVeR commented Aug 29, 2016 •
edited
Loading

From #27:

Unfortunately, I've found that my local repository clone had core.autocrlf set to false (and most of the files were commited to SVN with CRLF anyways, so we'd need to take care of that sooner or later). I've enabled this option now, so for some time it'll be harder for me to review my own pull requests, because there will be many line endings conversions.

We need to convert all the text files ASAP (e.g. from the current point in develop) because it's already starting to create problems in #27.

Convert each top-level directory in a separate commit to make review and testing easier (yes, I'm waiting for tests fails in middle of this).
@ForNeVeR ForNeVeR mentioned this issue Aug 29, 2016
Closed
19 tasks
@ForNeVeR ForNeVeR self-assigned this Aug 29, 2016
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: add line conversion script
a5496fa
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in bedrock directory
e2de080
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in build directory
bd76602
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in ConsoleClient directory
5c3d304
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in docs directory
b361465
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in Example directory
82a33e8
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in jabber directory
aa735de
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in muzzle directory
6c262f5
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in netlib.Dns directory
bf74c21
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: convert lines in Scripts directory
70fefef
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: line conversion in stringprep directory
14387ef
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: line conversion in test directory
eefa616
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: line conversion in VB.Example directory
b947606
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: line conversion in xpnet directory
34d3df3
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: line conversion in root directory
ea71f4e
@ForNeVeR ForNeVeR mentioned this issue Aug 30, 2016
Merged
2 tasks
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: stabilize line endings in HttpSocketTest
476aa7e 
Now they aren't dependent on platform and/or git settings.
ForNeVeR added a commit that referenced this issue Aug 30, 2016
@ForNeVeR
#28: delete line ending conversion script
335b053 
It has no use anymore.
@ForNeVeR ForNeVeR mentioned this issue Aug 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
kind:refactor
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CRLF conversion xmppo/Jabber-Net
1 participant
@ForNeVeR