Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on MacOS 10.13 (last supported OSX for CUDA) #104

Merged
merged 1 commit into from
May 14, 2021

Conversation

Spudz76
Copy link
Contributor

@Spudz76 Spudz76 commented May 14, 2021

Previously the configure step could not find CUDA or NVRTC libraries within Toolkit directory. When XMRIG_OS_APPLE is set, search the correct subdirectories. Clean up the default search path for all non-Apple.

MacOS High Sierra (10.13) compiler is customized clang 10.0.0 and needs -std= added to CFLAGS as c99/c++11 are not default, leading to compilation crashes.

Mute CMP0042 warning by setting policy to NEW; it doesn't seem like it matters, or policy NEW already works.

@Spudz76
Copy link
Contributor Author

Spudz76 commented May 14, 2021

Leads to successful build of libxmrig-cuda.dylib, which seems to load well enough to say no devices on the test platform which is a VM and has no actual GPU. Assume it would work, needs a real Mac w/GPU to test.

@Spudz76 Spudz76 mentioned this pull request May 14, 2021
@xmrig xmrig merged commit d2afbe5 into xmrig:dev May 14, 2021
@Spudz76
Copy link
Contributor Author

Spudz76 commented May 14, 2021

Note highest supported CUDA Toolkit is 10.2 which is the last version with any MacOS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants