Repair NVRTC DLL copy phase for all CUDA versions forever #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Thank you. Small defense for old garbage fixed-logic: CUDA 10.0 was latest version and it was work with 8.0, this code was added mostly for https://buildbot.xmrig.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building against CUDA 10.1 did not post-copy any DLLs due to garbage fixed-logic
Building against CUDA 8 same deal
Changed to GLOB so now it will hunt and copy them regardless what the version.
** "forever" defined as: until nvidia decides to completely rename them, or something dumb