-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AUTO_HUGEPAGE feature to disable writing to nr_hugepages #2391
Open
Spudz76
wants to merge
1
commit into
xmrig:dev
Choose a base branch
from
Spudz76:dev-featureAutoHugepage
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
May 20, 2021 03:32
373d720
to
10783af
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
5 times, most recently
from
September 22, 2021 15:40
e4e4eac
to
b05da46
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
October 5, 2021 19:52
0dd0186
to
cd21f48
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
October 13, 2021 01:07
fabdb50
to
fe60f37
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
October 25, 2021 21:57
278231b
to
e678d7f
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
November 2, 2021 12:21
ca17ec5
to
0659178
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
November 11, 2021 11:38
0659178
to
99e7ef5
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
7 times, most recently
from
December 3, 2021 19:27
64228f0
to
5b03bfa
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
December 19, 2021 18:12
9188cb3
to
4253090
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
December 30, 2021 16:36
4253090
to
82213c2
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
January 18, 2022 03:18
82213c2
to
b609af5
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
3 times, most recently
from
February 5, 2022 10:29
a614c95
to
c768d9b
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
February 16, 2022 15:47
c768d9b
to
62f31ae
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
April 6, 2022 06:04
0d47555
to
f2d5523
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
April 20, 2022 15:02
be8dc5b
to
2a6ba53
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
May 6, 2022 00:51
2a6ba53
to
7970fc3
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
May 21, 2022 11:43
77d1cdc
to
af4ff8e
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
June 12, 2022 20:55
af4ff8e
to
f500726
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
June 28, 2022 04:12
b118440
to
604ba06
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
July 3, 2022 16:11
604ba06
to
b34e458
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
August 26, 2022 00:20
4217905
to
640038d
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
4 times, most recently
from
September 22, 2022 03:35
531e709
to
5472f59
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
October 1, 2022 17:35
a561096
to
4354069
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
October 11, 2022 02:34
4354069
to
ca09aa1
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
October 24, 2022 12:04
ca85f20
to
58b825c
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
November 19, 2022 20:52
58b825c
to
df09f97
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
December 17, 2022 16:05
df09f97
to
f32dc65
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
March 7, 2023 21:42
dcf463f
to
46976f2
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
April 1, 2023 21:40
46976f2
to
5b08ac0
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
2 times, most recently
from
May 23, 2023 22:49
082cdf0
to
50ecab3
Compare
Spudz76
force-pushed
the
dev-featureAutoHugepage
branch
from
July 12, 2023 08:31
50ecab3
to
6c80983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is need to set/limit hugepages to a smaller amount (up to for example 40 which covers most algos) but do not want the full RandomX allocation (not enough memory, other activities require slack space, only running one of 12 cores anyway so who cares about the speedup for a single-thread calm side mining, etc). But when running as root for MSR access or other reasons the automatic reservation grabs more hugepages.
This adds a compile-time feature to disable writing to
nr_hugepages
, so that the described use-case works nicely (reserve your own or suffer perhaps intentionally without enough, like older versions). Compile-time was easier to wire and as a power user feature it didn't seem like adding to main config made any sense. It can be converted to an argument/config item later if it appears to be a useful medium-power-user (power-noob?) feature. Also I didn't feel like wiring all that and adding it to docs lol.Note the default is ON which means be the same as it has been (yes, do autoreserve) and intentionally setting it OFF causes no-writing mode (like old versions).