Fix CI Integration Workflow #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zombieobject
force-pushed
the
em/ci-testing
branch
from
5fc1d56
to
e09e421
Compare
zombieobject
force-pushed
the
em/ci-testing
branch
6 times, most recently
from
46e8021
to
0997816
Compare
This reverts commit 0c1b5eb.
zombieobject
force-pushed
the
em/ci-testing
branch
from
0997816
to
77e6e91
Compare
zombieobject
force-pushed
the
em/ci-testing
branch
from
77e6e91
to
b7bd50f
Compare
nplasterer
reviewed
May 3, 2024
|
Do you mind updating this text file so we know which version of the binarys this is https://github.com/xmtp/xmtp-android/blob/main/library/src/main/java/libxmtp-version.txt |
Yes, I just pushed an updated version file now. Thanks for pointing that out. |
…into em/ci-testing
…into em/ci-testing
nplasterer
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the Integration CI workflow. The libxmtp binaries have been updated and failing tests have been marked
@Ignoredfor now to focus on the failure point which was related to the presence of dynamically linked libatomic symbols as noted in the following libxmtp PR: xmtp/libxmtp#709