feat: add canMessage(address) to Client #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccartney
force-pushed
the
daniel-can-message
branch
2 times, most recently
from
b0fc83d
to
31fa3d3
Compare
dmccartney
commented
Jan 3, 2023
Comment on lines
-30
to
+32
| if (_contacts.containsKey(walletAddress)) { | ||
| return _contacts[walletAddress].toList(); | ||
| var cached = _contacts[walletAddress].toList(); | ||
| if (cached.isNotEmpty) { | ||
| return cached; |
There was a problem hiding this comment.
Previously we were caching empty lookup results -- so once a lookup returned no contacts for an address, it would stop checking. This changes things so we only cache contact lookups that find results.
nplasterer
approved these changes
Jan 3, 2023
dmccartney
force-pushed
the
daniel-can-message
branch
from
31fa3d3
to
b456e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to check if an address can receive a message.