feat: low-level support for v1 messaging #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccartney
commented
Nov 30, 2022
Comment on lines
+221
to
+229
| // This creates 2 users connected to the API and sends DMs | ||
| // back and forth using message API V1. | ||
| test( | ||
| skip: "manual testing only", | ||
| "v1 messaging: intros, reading, writing, streaming", | ||
| () async { | ||
| // Setup the API clients. | ||
| var aliceApi = Api.create(host: '127.0.0.1', port: 5556, isSecure: false); | ||
| var bobApi = Api.create(host: '127.0.0.1', port: 5556, isSecure: false); |
There was a problem hiding this comment.
This test walks through the core of the functionality added.
dmccartney
force-pushed
the
daniel-v1-messaging
branch
2 times, most recently
from
b9d2033
to
20b68a8
Compare
dmccartney
force-pushed
the
daniel-v1-messaging
branch
from
20b68a8
to
9a556ce
Compare
dmccartney
commented
Nov 30, 2022
| /// This performs a variation of the X3DH protocol to establish a shared secret | ||
| /// between "me" and "peer". | ||
| /// NOTE: it varies based on whether "me" is the recipient (vs sender). | ||
| Uint8List compute3DHSecret( |
There was a problem hiding this comment.
Here's the careful crypto bits.
There was a problem hiding this comment.
cc @mkobetic in case you want to follow along on the crypto pieces!
elisealix22
approved these changes
Nov 30, 2022
| /// This performs a variation of the X3DH protocol to establish a shared secret | ||
| /// between "me" and "peer". | ||
| /// NOTE: it varies based on whether "me" is the recipient (vs sender). | ||
| Uint8List compute3DHSecret( |
There was a problem hiding this comment.
cc @mkobetic in case you want to follow along on the crypto pieces!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the low-level bits required for V1 messaging.
It includes
PublicKeysand v2SignedPublicKeys