Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify source of API concurrency errors #391

Closed
neekolas opened this issue May 21, 2024 · 0 comments
Closed

Identify source of API concurrency errors #391

neekolas opened this issue May 21, 2024 · 0 comments
Assignees
@neekolas @richardhuaaa

Comments

@neekolas
Copy link
Collaborator

When our libxmtp tests are run in parallel we are seeing errors like this:

called `Result::unwrap()` on an `Err` value: Api(Api(xmtp::error::Error(IdentityError, Status { code: Unknown, message: "ERROR: could not serialize access due to read/write dependencies among transactions (SQLSTATE 40001)", metadata: MetadataMap { headers: {"content-type": "application/grpc"} }, source: None })))

This is suspicious, since all the tests are using random wallets/inboxes. Somehow we are running into transaction issues with conflicts that span multiple inboxes.
@neekolas neekolas mentioned this issue May 21, 2024
Merged
neekolas added a commit to xmtp/libxmtp that referenced this issue May 21, 2024
@neekolas
Identity E2E integration (#755)
76010ba 
## tl;dr

- Gets identity working end to end, with tests (pretty much) all uncommented
- Updates bindings to have all required methods
- Removes a bunch of TODOs in the code

## Follow-ups

There are a few changes I had to make to get everything passing that need some follow-up.
- xmtp/xmtp-node-go#391
- #760
- #761
- #750
- #762
- #763

There are also many places that need better test coverage.
@neekolas neekolas mentioned this issue May 28, 2024
Merged
@neekolas neekolas self-assigned this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neekolas neekolas

@richardhuaaa richardhuaaa

Labels
None yet
Projects
MLS Work
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neekolas @richardhuaaa