Push notifications #27
Conversation
…t-native into np/expo-push-test
|
|
||
| Function("registerPushToken") { (pushServer: String, token: String) in | ||
| // TODO | ||
| } | ||
|
|
||
| Function("subscribePushTopics") { (topics: [String]) in | ||
| // TODO | ||
| } | ||
|
|
||
| AsyncFunction("decodeMessage") { (topic: String, encryptedMessage: String, conversationID: String?) in | ||
| // TODO | ||
| } |
There was a problem hiding this comment.
The spacing looks normal on in my VSCode and XCode so not sure why it looks like this here.
| @@ -92,7 +95,7 @@ class XMTPModule : Module() { | |||
| Name("XMTP") | |||
| Events("sign", "authed", "conversation", "message") | |||
|
|
|||
| Function("address") { | |||
| Function("address") { clientAddress: String -> | |||
There was a problem hiding this comment.
App wouldn't compile unless I added these but haven't hooked up the testing stuff to actually use them.
There was a problem hiding this comment.
Thank you for this amazing engineering, @nplasterer - and also for taking the time to update the README! So grateful -- LGTM!
| @@ -18,6 +18,7 @@ export default function ConversationListView({ | |||
|
|
|||
| async function refreshConversations() { | |||
| const conversations = await client.conversations.list(); | |||
| XMTPPush.subscribe(conversations.map((c) => c.topic)); | |||
There was a problem hiding this comment.
It only subscribes once you refresh the list view. Not super great at react couldn't figure out how to get it to subscribe on streaming conversations but this is a minor detail and we can improve it later.
|
|
||
| Function("registerPushToken") { (pushServer: String, token: String) in | ||
| // TODO | ||
| } | ||
|
|
||
| Function("subscribePushTopics") { (topics: [String]) in | ||
| // TODO | ||
| } | ||
|
|
||
| AsyncFunction("decodeMessage") { (topic: String, encryptedMessage: String, conversationID: String?) in | ||
| // TODO | ||
| } |
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Android part of #22
Rewatch.Screen.Recording.-.2023-05-04.at.4.07.09.PM.mp4
Will do iOS in a follow up.