Reactions #1
Merged
Reactions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rygine
reviewed
Jul 14, 2023
rygine
reviewed
Jul 14, 2023
rygine
reviewed
Jul 14, 2023
rygine
reviewed
Jul 14, 2023
rygine
reviewed
Jul 14, 2023
|
|
||
| type ReactionString = keyof typeof defaultReactions; | ||
| type ReactionEmoji = (typeof defaultReactions)[ReactionString]; | ||
| type ReactionEntries = [ReactionString, ReactionEmoji][]; |
There was a problem hiding this comment.
did some type-fu here so typescript is happier
rygine
reviewed
Jul 14, 2023
| } | ||
| )} | ||
|
|
||
| {!isFullyReacted ? ( |
There was a problem hiding this comment.
if we've reacted with every available emoji, don't display anything else
There was a problem hiding this comment.
Is this stateful per person in the chat? Like only do I not see it if I've react with all of them but others in the chat would still see them?
There was a problem hiding this comment.
yep, this is a per person, per message state.
rygine
reviewed
Jul 14, 2023
| </button> | ||
| ); | ||
| }) | ||
| .filter(Boolean)} |
There was a problem hiding this comment.
this filters out emoji that have already been reacted with
rygine
reviewed
Jul 14, 2023
| ) : ( | ||
| <button | ||
| className="text-xs text-zinc-500" | ||
| onClick={() => setIsReacting((prev) => !prev)} |
There was a problem hiding this comment.
minor update here to prevent a possible rare edge case where the committed react state may not represent the actual state
daria-github
approved these changes
Jul 14, 2023
nakajima
commented
Jul 14, 2023
Co-authored-by: Pat Nakajima <patnakajima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in @rygine's work from xmtp/xmtp-js#402, I started adding reactions here. We can delete the copy/pasted content types once they land in the content types repo.
Note: There's still some race conditions here that we'll need to iron out.
Screen.Recording.2023-06-20.at.5.18.19.PM.mov