Add ContentTypeReaction #402
Conversation
| } | ||
|
|
||
| export type ReactionParameters = Pick<Reaction, 'action' | 'reference'> & { | ||
| encoding: 'UTF-8' |
There was a problem hiding this comment.
i hardcoded this type to eliminate the need for an enum. we can add more in the future if necessary.
| return { | ||
| action: content.parameters.action, | ||
| reference: content.parameters.reference, | ||
| content: new TextDecoder().decode(content.content), |
There was a problem hiding this comment.
Do we want to put some limit (even a relatively large one like 1kb) on the size of the content? I can't think of a valid use-case for large content
There was a problem hiding this comment.
base64 encoded SVG, images, etc... could be a thing 🤔
There was a problem hiding this comment.
Hmmm. For something that different from an emoji, we wouldn't want some other metadata to tell the recipient "decode this like an image".
Is that really an intended use-case of this version of the content type?
There was a problem hiding this comment.
AFAIK for this initial version, we're supporting the standard set of emojis via string tokens, so smile => 😄 (:smile:). this will allow clients to use their own custom emojis like Slack. i don't think the intent of this content type is to store actual content like images, SVGs, etc. so it might make sense to limit the length.
| versionMinor: 0, | ||
| }) | ||
|
|
||
| export type Reaction = { |
There was a problem hiding this comment.
wonder if we should be namespacing things like this to avoid potential clashes in the future. maybe something like ContentTypeReactionContent or similar?
|
Curious why we are doing this here and not in https://github.com/xmtp/xmtp-js-content-types. Seems like having it in a separate repo would make it easier to share with RN |
great call out! this is my first content type. wasn't sure where to put it and i saw the typing notification here, so thought it might be appropriate. |
|
this will be added to a different repo |
Proposal: https://github.com/orgs/xmtp/discussions/36
Issue: https://github.com/xmtp-labs/hq/issues/1030
This PR adds the reaction content type with adjustments from the proposal as outlined in the comments of the issue.
TL;DR on the changes from the proposal:
emoji=>content, to be interpreted by client to allow for custom reactionsaction, to allow for removing a reaction