XNIO-386: XNIO001009 includes a stack trace #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmlloyd Should I file a jira issue for this? |
|
Yes, there should be a JIRA for each PR. |
carterkozak
changed the title
|
Thanks, I've filed https://issues.redhat.com/browse/XNIO-386 |
fl4via
approved these changes
Sep 25, 2021
|
There is an ongoing work I'm doing to fix the SSL failures, it should be ready to be submitted soon. |
Previously the string value of the exception was interpolated into the message rather than logged with a stack trace.
fl4via
force-pushed
the
ckozak/stack_trace_logging
branch
from
7f81d9b
to
132f105
Compare
|
I updated the PR to include the fixes in 3.x and to add the Jira to the commit message. I'm merging this soon. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the string value of the exception was interpolated
into the message rather than logged with a stack trace.