[XNIO-394] Fix closing of SSL connections thus preventing broken pipe errors #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nduits/channels/connection in JsseSSlConduitEngine until closeEngine runs. Prevents broken pipe errors, where a shutdown reads here and a shutdown writes there, for example, or a premature close, could lead to the invocation of close listeners or to the closing of conduits before the engine is fully closed.
…d to prevent a broken pipe error on corner cases. Invoking closeOutbound on a read operation when status is need wrap and doFlush() returned positive can lead to Broken pipe errors
…nt to first handshake. The special treatment was an attempt to make some corner cases work, such as when closing the channel right away. Not only this is unnecessary, as giving that special treatment can lead to not following the JsseEngine behavior to a T in certain scenarios, as the tests show.
…eft in the buffer before reading from socket.
…ake sure that, no matter what, engine is invoked and waited upon before closing conduits More info: - the new state machine makes sure that we behave consistently with regards of readClosed/writeClosed invocations and isRead/WriteShutdown to callers - internally, though, we do not invoke internal channels and connection until engine has given its okay - notice that, by having two layers (SSL over non-SSL) and two layers on hierarchy (super class being non-SSL, subclass being SSL), invoking the super class methods makes us enter a simpler state machine that just takes care of closing everything if everything is shutdown, this is exactly the issue we want to avoid, because not only it can cause Broken pipe errors, but it can also cause a close listener to be invoked and close the connection while read/write listeners have not fully taken care of their business
…inition, so sometimes they just fail, and add tests for abrudpt attempts to close the channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/XNIO-394
3.x PR: #260