Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XNIO-385] Ensure that the close method waits until the server key ca… #309

Merged
merged 1 commit into from Apr 19, 2024

Conversation

yersan
Copy link
Contributor

@yersan yersan commented Oct 4, 2023

…ncellation releases the resources

Follows up on #248 which was closed due to CI issues. However, I'm unable to see the issues again, and WildFly and WildFly Core testsuite pass with 3.8.x plus this patch.

Jira issue: https://issues.redhat.com/browse/XNIO-385
3.x PR: #310
3.9 PR: #325

CC @fl4via

@dmlloyd
Copy link
Member

dmlloyd commented Oct 4, 2023

The change looks good to me, but again we'll want to check WildFly on all supported OSes to make sure there isn't some sneaky behavior (which sometimes there is with NIO).

@fl4via
Copy link
Contributor

fl4via commented Mar 1, 2024

The change looks good to me, but again we'll want to check WildFly on all supported OSes to make sure there isn't some sneaky behavior (which sometimes there is with NIO).

Ok, @dmlloyd that's a good point. I will run the suggested tests and I'll post a link here so we can fully validate the PR and merge it

@fl4via
Copy link
Contributor

fl4via commented Apr 8, 2024

The change looks good to me, but again we'll want to check WildFly on all supported OSes to make sure there isn't some sneaky behavior (which sometimes there is with NIO).

Ok, @dmlloyd that's a good point. I will run the suggested tests and I'll post a link here so we can fully validate the PR and merge it

Working on this today

@fl4via
Copy link
Contributor

fl4via commented Apr 19, 2024

The change looks good to me, but again we'll want to check WildFly on all supported OSes to make sure there isn't some sneaky behavior (which sometimes there is with NIO).

Ok, @dmlloyd that's a good point. I will run the suggested tests and I'll post a link here so we can fully validate the PR and merge it

Working on this today

Here is the check: https://github.com/fl4via/xnio/actions/runs/8690905952
There are some failures, all of which seem unrelated.

@fl4via fl4via merged commit de55d0a into xnio:3.8 Apr 19, 2024
7 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants