Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XNote window stopped working in TB 90 #65

Open
zevrix opened this issue Jul 3, 2021 · 23 comments
Open

XNote window stopped working in TB 90 #65

zevrix opened this issue Jul 3, 2021 · 23 comments

Comments

@zevrix
Copy link

zevrix commented Jul 3, 2021

xnote-tb90

First, I know TB 90 is still in beta. BUT, unlike the released TB 78, it doesn't crash constantly.

XNote actually did work normally for at least a week in TB 90. It just stopped now for unclear reason. Maybe after updating to 90b3? Not sure.

Now I get the attached error in the XNote window, which makes any editing and creating new notes impossible.

Other aspects are not affected - that is, existing notes are shown in the column and the body of the message.

macOS 11.4

@zevrix
Copy link
Author

zevrix commented Jul 23, 2021

Additional info:

It looks like this issue is intermittent. After relaunching TB, the issue sometimes goes away and sometimes persists. Right now it's working after I relaunched TB several times. But I don't know if I can count on this in the future.

TB 91.0b2

@opto
Copy link
Collaborator

opto commented Jul 27, 2021

later tonight, I will upload a version to github (releases) that works here on 91.0b4.

Please be so kind to test.
thanks, Klaus

@zevrix
Copy link
Author

zevrix commented Jul 29, 2021

Thanks Klaus,

Just checking if you have uploaded it yet as the latest one I see on github is still from March 9 so far... Or is there another location?

@opto
Copy link
Collaborator

opto commented Aug 1, 2021

please try 3.2.1

@opto
Copy link
Collaborator

opto commented Aug 1, 2021

https://github.com/xnotepp/xnote/releases/tag/v3.2.1

@opto opto added the resolved Issue resolved but needs finalization before it can be closed, e.g., release or fix confirmation. label Aug 1, 2021
@zevrix
Copy link
Author

zevrix commented Aug 2, 2021

thanks for the update, but unfortunately it didn't make any difference.

i still get exactly the same error when trying to view existing note or create a new one:
Untitled 44

TB 91.0b5 (Mac)

@mms1406
Copy link

mms1406 commented Aug 20, 2021

Same by me 91.0.1

@opto
Copy link
Collaborator

opto commented Aug 22, 2021

just tested again on win 10 21H1, and it is working there.

Is there anything in error console? you get it in a submenu of tools or by ctrl-shift-j on win, I think ctrl is another key on a mac.

@opto opto removed the resolved Issue resolved but needs finalization before it can be closed, e.g., release or fix confirmation. label Aug 22, 2021
@opto opto mentioned this issue Aug 22, 2021
@opto
Copy link
Collaborator

opto commented Sep 1, 2021

I was told this can be related to OS language and TB language. @mms1406 and @zevrix , what are your settings?

@mms1406
Copy link

mms1406 commented Sep 1, 2021

Win 11 German, TB 92.0b4 German

@zevrix
Copy link
Author

zevrix commented Sep 1, 2021

I was told this can be related to OS language and TB language. @mms1406 and @zevrix , what are your settings?

Like I mentioned, this issue is coming and going. It didn't work for a week again when I reported it last time. Obviously, when I was just about to submit the log you asked for, XNote started working again after a relaunch. So it's been working for the last few days - and I'll now keep TB open for as long as possible once again.

macOS 11.5 U.S. English
TB 92.0b4 English (United States)

@opto
Copy link
Collaborator

opto commented Sep 3, 2021

what other addons do you have? I was just able to reproduce this (at least once) after installing expression search NG after XNote. And when deinstalling expression search, the xml error was gone.

Unfortunately, no error directly in the two addons, only erors deep in TB code, not even claiming that they have been triggered by the addons (that is more difficult to debug than a direct error in the addon).

@opto
Copy link
Collaborator

opto commented Sep 3, 2021

correction: after reactivating expression search, xnote is still working. Maybe it is related to the PC going to "sleep"?

@zevrix
Copy link
Author

zevrix commented Sep 9, 2021

i guess it has something to do with the TB startup process. because if I open TB and XNote is working, then it will work as long as TB is open. if I relaunch TB, then it's a hit and miss. that's why I'm trying to keep TB open for as long as possible when XNote is working.

@jssilva25
Copy link

jssilva25 commented Nov 21, 2021

Here it doesn't work at all on macOS 10.15.7 Catalina, TB 91.3.2 x64.
It's present and enabled on the addons list but I can't see it on any menu, neither on the hamburger nor on /tools where it used to be.

@5meter
Copy link

5meter commented Dec 8, 2021

here it didn't work either but with update and restart of TB it now is back on track.
now TB 91.4.0
mac OS 10.14.6 (mojave)
both in german

@opto
Copy link
Collaborator

opto commented Dec 9, 2021

my bookmarks addon had a 'race' condition where it manipulated TB before TB was ready.
Unfortunately, TB does not indicate at startup when it is ready to load the addons.

I wll put the same solution into xnote (new release in a few days).

Klaus

@zevrix
Copy link
Author

zevrix commented Dec 9, 2021

It looks like I found a pattern how to make XNote work consistently after relaunch:

1. If after launching TB you click a message that does NOT have XNote assigned, then create a note, then XNote will work without errors (you can just dismiss the empty note you created).

2. If, however, after launching TB you select a message that has an XNote assigned, then it's a hit and miss: you may get the "XML parsing error", or you may not.

Therefore, if you always perform the pattern 1 described above, XNote should always work as expected (knock on the wood).

TB 95.0b5
macOS 12

@opto
Copy link
Collaborator

opto commented Dec 9, 2021

thanks for testing that!

@opto
Copy link
Collaborator

opto commented Dec 9, 2021

@zevrix
Copy link
Author

zevrix commented Dec 12, 2021

when i try to install 3.2.9. from .xpi file it gives me error:

"XNote++ could not be installed because it's not compatible with Thunderbird 95.0"

@zevrix
Copy link
Author

zevrix commented Dec 13, 2021

ok i disabled extensions.checkCompatibility... so I could install it.

i don't see any changes in XNote behavior.

that is, it works consistently IF after launching TB you select a message that doesn't have a note and create a new note (which you can then dismiss).

otherwise, you can still get the XML Parsing Error.

TB 96.0
macOS Monterey

@zevrix
Copy link
Author

zevrix commented Dec 13, 2021

actually, now an old bug returned:

after launching TB, XNote notes do not appear in the unified Inbox.

however, they can be quickly restored:

select an individual inbox for an email account. notes do appear there. switch back to the unified Inbox - notes now appear there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants