Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbox/pkgs): build libvfn as release #369

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

karlowich
Copy link
Contributor

@karlowich karlowich commented Oct 24, 2023

Currently we are building libvfn with debug enabled, this leads to unwanted debug messages getting printed in our CI. Silence these by building as release.

This closes #324

Currently we are building libvfn with debug enabled, this leads to
unwanted debug messages getting printed in our CI.
Silence these by building as release.

Signed-off-by: Karl Bonde Torp <k.torp@samsung.com>
Copy link
Member

@safl safl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@safl safl merged commit d4ebbb6 into xnvme:next Oct 25, 2023
30 checks passed
@safl safl added this to the v0.7.2 milestone Nov 7, 2023
@karlowich karlowich deleted the libvfn-release branch November 29, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants