-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade thrift (again) #347
Conversation
The usql build is failing with the `all` tag. This regression was introduced with commit 1f27d36 which upgrade Thrift from v0.13 to v0.14.2, see xo@1f27d36e However since Thrift >= v0.13, there is a breaking change which was introduced, see apache/thrift@e79f764f09afd And sqlflow.org/gohive needs to Thrift <= v0.13 to work. A resolution is to downgrade thrift to v0.13 again: ```bash $ go get github.com/apache/thrift@0.13.0 downgraded github.com/apache/thrift v0.15.0 => v0.13.1-0.20191017214740-b75e88a33d67 downgraded github.com/beltran/gohive v1.5.2 => v1.3.0 ``` Because this problem already occured and was fixed with xo#206, I propose to build usql with the all `tag` during the test pipeline to detect this kind of regression more easily :)
I also opened a pull-request to gohive to upgrade the Thrift version to v0.16.0 and fix this issue definitively :) See sql-machine-learning/gohive#70 I hope we can update |
@anthonyroussel appreciate the work. Do you actually use this driver, or were you just testing with |
Thank you for your review! :) No I don't use this driver. My problem was that I could not update the |
If you're distributing I'd highly suggest using the set of tags within the
I would even suggest using |
Thanks for your advice! :) I will check this to make sure that in nixpkgs we only use these tags to build usql. Do you plan to release a v0.11.1 of usql soon? |
@anthonyroussel likely this weekend if I have enough time. Unfortunately, I have to manually build the release artifacts on VMs because of the CGO dependencies. I was going to do it yesterday, but became busy with other development tasks. |
Hello :)
The usql build is failing with the
all
tag:This regression was introduced with commit 1f27d36 which upgrade Thrift from v0.13 to v0.14.2, see 1f27d36e
However since Thrift >= v0.13, there is a breaking change which was introduced, see apache/thrift@e79f764f09afd
And sqlflow.org/gohive needs to Thrift <= v0.13 to work.
A resolution is to downgrade thrift to v0.13 again:
Because this problem already occured and was fixed with #206, I propose to build usql with the all
tag
during the test pipeline to detect this kind of regression more easily :)