Removing empty (errored) generated svgs

xo · Jan 16, 2024 · a90d734 · a90d734
1 parent 08d366a
commit a90d734
Show file tree

Hide file tree

Showing 11 changed files with 4 additions and 2 deletions.
diff --git a/testdata/compiled/interactive_1d_geo_brush.vg.json.svg b/testdata/compiled/interactive_1d_geo_brush.vg.json.svg
diff --git a/testdata/compiled/interactive_airport_crossfilter.vg.json.svg b/testdata/compiled/interactive_airport_crossfilter.vg.json.svg
diff --git a/testdata/lite/interactive_1d_geo_brush.vl.json.svg b/testdata/lite/interactive_1d_geo_brush.vl.json.svg
diff --git a/testdata/lite/interactive_airport_crossfilter.vl.json.svg b/testdata/lite/interactive_airport_crossfilter.vl.json.svg
diff --git a/testdata/vega/clock.vg.json.svg b/testdata/vega/clock.vg.json.svg
diff --git a/testdata/vega/hypothetical-outcome-plots.vg.json.svg b/testdata/vega/hypothetical-outcome-plots.vg.json.svg
diff --git a/testdata/vega/pacman.vg.json.svg b/testdata/vega/pacman.vg.json.svg
diff --git a/testdata/vega/platformer.vg.json.svg b/testdata/vega/platformer.vg.json.svg
diff --git a/testdata/vega/watch.vg.json.svg b/testdata/vega/watch.vg.json.svg
diff --git a/testdata/vega/zoomable-circle-packing.vg.json.svg b/testdata/vega/zoomable-circle-packing.vg.json.svg
diff --git a/vegagoja_test.go b/vegagoja_test.go
@@ -89,8 +89,10 @@ func testRender(t *testing.T, ctx context.Context, testName, name string, timeou
 		t.Logf("---\n%s\n---", s)
 	}
 	t.Logf("duration: %s", total)
-	if err := os.WriteFile(name+".svg", []byte(s), 0o644); err != nil {
-		t.Fatalf("expected no error, got: %v", err)
+	if s = strings.TrimSpace(s); len(s) != 0 {
+		if err := os.WriteFile(name+".svg", []byte(s), 0o644); err != nil {
+			t.Fatalf("expected no error, got: %v", err)
+		}
 	}
 }