Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling maximalThumbsSize prop #44

Closed
gamegee opened this issue Mar 1, 2019 · 6 comments
Closed

Enabling maximalThumbsSize prop #44

gamegee opened this issue Mar 1, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gamegee
Copy link

gamegee commented Mar 1, 2019

Do you want to request a feature or report a bug?
Request a feature

What is the current behavior?
The API does not provide a way to pass maximalThumbsSize as props.
It could be really helpful for UI reasons (sometimes the size of your scrollbar almost fit its track container size)

What is the expected behavior?
Provide the maximalThumbsSize prop. Given that maximalThumbsSize, the scrollbar should change the way the position is computed (I guess).

@xobotyi
Copy link
Owner

xobotyi commented Mar 1, 2019

You can set the paddings for track and maximal thumb size will be respective for them (paddings).

@xobotyi xobotyi self-assigned this Mar 1, 2019
@xobotyi xobotyi added the enhancement New feature or request label Mar 1, 2019
@gamegee
Copy link
Author

gamegee commented Mar 1, 2019

Ok but if we have a vertical scrollbar and I set paddings (top and bottom), my thumb would not be able to reach the top and the bottom of the track.

In this example I'm on the top of the scrolling content:
image

@xobotyi
Copy link
Owner

xobotyi commented Mar 1, 2019

Thats true.
I just can't imagine situation when you have to set max size. Thumb size is intuitive represents how much content you see now and how much still "out there". If to set the maximal size it will:

  1. break that representation
  2. slow down the lib a bit due to extra calculations for each scrolling step =
    not sure if it is necessary.

Anyways i'm bisy with package rework yet, if anywone will vote for that feeature too i'll add it somewhere around 3.4.x-3.5.x versions.

@gamegee
Copy link
Author

gamegee commented Mar 1, 2019

Here is an example of something I want to avoid in my UI:

image

But ofc I get your point. I could also do a pull request if you need - leaving the default computation when maximalThumbsSize is not set.

@xobotyi
Copy link
Owner

xobotyi commented Mar 1, 2019

@gamegee no sense, cause lib will be rewritten from scratch onto TS since 3.2

@xobotyi xobotyi added this to the 4.0 milestone Mar 6, 2019
xobotyi added a commit that referenced this issue Mar 6, 2019
Fixed #32 issue;
Fixed #39 issue;
Fixed #41 issue;
Fixed #42 issue;
Fixed #44 issue;
@xobotyi
Copy link
Owner

xobotyi commented Mar 18, 2019

Feature added in 4.0.0-aplha

@xobotyi xobotyi closed this as completed Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants