Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ColorPinWidget and ColorPicker #1954

Open
brusherru opened this issue Feb 6, 2020 · 1 comment
Open

Tweak ColorPinWidget and ColorPicker #1954

brusherru opened this issue Feb 6, 2020 · 1 comment

Comments

@brusherru
Copy link
Contributor

A list of little tweaks:

  1. Replace Saturation/Lightness box inside ColorPicker with the triangle, like on the picture below (Affinity Designer)
    image
  2. Add the "Revert" button and preview for the initial color inside ColorPicker
  3. Render pin widgets in accordance with deduced types on generic pins. So when deduced pin gets #FF00AA bound value it should be replaced with the ColorPinWidget and should provide a ColorPicker. But should be replaced on deducing another type (not when the input is empty). It's an unimplemented part of issue As a xoder I want to set color values with a picker control so that I can see the visual feedback immediatelly #1945.
  4. Show squares with the bound color over the color pins and inside tweak-color and linked watch nodes on the patch board.
@evgenykochetkov
Copy link
Contributor

Also, the little hue selector ring seems to be slightly off-center.
Here it's closer to the inner edge:
Screen Shot 2020-02-19 at 15 44 16
And here it's closer to the outer edge:
Screen Shot 2020-02-19 at 15 44 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants