Change arduino-cli config on switch workspace #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenykochetkov
approved these changes
Oct 18, 2018
nkrkv
requested changes
Oct 19, 2018
| * | ||
| * :: ArduinoCli -> Path -> Promise Object Error | ||
| */ | ||
| export const updateWorkspace = async (cli, newWsPath) => { |
There was a problem hiding this comment.
A possibly better name to match terminology: switchWorkspace
…out recreating wrapper object
…ly with arduino-cli without restarting the IDE
brusherru
force-pushed
the
refactor-workspace-path-handling
branch
from
b18b65c
to
46a55e9
Compare
nkrkv
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the user switched workspace and then tried to upload something onto the board or install package — arduino-cli works with the old workspace instead of newly selected one.
This PR make arduino-cli works always with the current user's workspace.
When he switches it — it changes arduino-cli
.cli-config.yml.