Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log position of compile/upload tabs on first show #1494

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix log position of compile/upload tabs on first show #1494

merged 1 commit into from
Oct 24, 2018

Conversation

brusherru
Copy link
Contributor

No description provided.

@brusherru brusherru self-assigned this Oct 22, 2018
@brusherru brusherru requested a review from a team October 22, 2018 15:14
@brusherru brusherru changed the base branch from master to 0.25.x October 22, 2018 15:15
@brusherru brusherru force-pushed the fix-log-position-on-first-show branch from 994e8fa to ed69338 Compare October 23, 2018 12:02
nkrkv
nkrkv requested changes Oct 24, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛

Expand the Deployment pane and note that top controls (tabs, sidebar buttons) get partially hidden.

@brusherru brusherru force-pushed the fix-log-position-on-first-show branch from ed69338 to ed03569 Compare October 24, 2018 12:54
@brusherru
Copy link
Contributor Author

@nkrkv fixed. Check it out, please!

@brusherru brusherru force-pushed the fix-log-position-on-first-show branch from ed03569 to 874247a Compare October 24, 2018 14:19
evgenykochetkov
evgenykochetkov approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nkrkv
nkrkv reviewed Oct 24, 2018
View reviewed changes
packages/xod-client/src/utils/components/Autoscroll.jsx Outdated
@@ -0,0 +1,98 @@
/*
Edited fork of `autoscroll-react` from
https://github.com/xodio/autoscroll-react.git#cbb3422461a28b40ca082d6a5f33f667508c3288
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The original should be the original original. And a note on what’s been changed:

  • onScrollFromBottom
  • scrollDown

nkrkv
nkrkv approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes essentially fix the bug.

Please, adjust the reference and merge.

@brusherru brusherru force-pushed the fix-log-position-on-first-show branch from 874247a to c1c3fe7 Compare October 24, 2018 16:09
@brusherru brusherru merged commit 9d32d5f into 0.25.x Oct 24, 2018
@brusherru brusherru deleted the fix-log-position-on-first-show branch October 24, 2018 17:05
@nkrkv nkrkv added the hotfix Issue/PR for a patch release label Nov 6, 2018
@nkrkv nkrkv mentioned this pull request Nov 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

Assignees

@brusherru brusherru

Labels
hotfix Issue/PR for a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brusherru @nkrkv @evgenykochetkov