Fix publisherName to match certificate's "Issued to" field #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopki
approved these changes
Nov 20, 2018
nkrkv
approved these changes
Nov 20, 2018
evgenykochetkov
force-pushed
the
fix-win-electron-publisher-name
branch
from
cfc38c9
to
5d6de3e
Compare
evgenykochetkov
added a commit
that referenced
this pull request
Nov 26, 2018
…lder config In #1555 we replaced it, but having both is a more bulletproof solution.
evgenykochetkov
added a commit
that referenced
this pull request
Nov 27, 2018
…lder config In #1555 we replaced it, but having both is a more bulletproof solution.
evgenykochetkov
added a commit
that referenced
this pull request
Nov 27, 2018
…lder config In #1555 we replaced it, but having both is a more bulletproof solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused problems with auto-update on Windows.
See electron-userland/electron-builder#1187 (comment)