Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on successful arduino libs installation #1575

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Fix error on successful arduino libs installation #1575

merged 2 commits into from
Nov 30, 2018

Conversation

evgenykochetkov
Copy link
Contributor

Closes #1546

@evgenykochetkov evgenykochetkov self-assigned this Nov 28, 2018
brusherru
brusherru approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taps is really not necessary here, but it's very strange that this changes fixes misleading error :)
Probably, we have a bug in tapP and it can hurt us in the future 🙈
But, approve :)

nkrkv
nkrkv approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@evgenykochetkov
Copy link
Contributor Author

evgenykochetkov commented Nov 28, 2018 •
edited
Loading

@brusherru, tapP is fine. tap from ramda@0.25.0 was the culprit. And because 0.25.0 ended up in asar file despite the fact that we use 0.24.1 everywhere the error was reproducible only in production build.

@evgenykochetkov evgenykochetkov force-pushed the fix-1546-misleading-error-when-installing-arduino-libs branch from 143cd26 to 8148bc8 Compare November 29, 2018 14:24
@evgenykochetkov evgenykochetkov force-pushed the fix-1546-misleading-error-when-installing-arduino-libs branch from 8148bc8 to 887dc20 Compare November 30, 2018 09:55
@evgenykochetkov evgenykochetkov merged commit b6ace22 into master Nov 30, 2018
@evgenykochetkov evgenykochetkov deleted the fix-1546-misleading-error-when-installing-arduino-libs branch November 30, 2018 11:33
@evgenykochetkov evgenykochetkov mentioned this pull request Dec 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evgenykochetkov @nkrkv @brusherru