Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate subscriptions to IPC events n reload #1587

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Fix duplicate subscriptions to IPC events n reload #1587

merged 1 commit into from
Dec 13, 2018

Conversation

evgenykochetkov
Copy link
Contributor

Closes #1551, #1583

@evgenykochetkov evgenykochetkov self-assigned this Dec 12, 2018
@evgenykochetkov evgenykochetkov force-pushed the fix-1551-double-subscriptions-to-IPC-events-on-reload branch from e2c5360 to bc360a8 Compare December 12, 2018 16:40
@nkrkv nkrkv self-requested a review December 12, 2018 16:56
nkrkv
nkrkv approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, it works! Definitely more clear in code than it was 👍

brusherru
brusherru approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov merged commit c4a44b8 into master Dec 13, 2018
@evgenykochetkov evgenykochetkov deleted the fix-1551-double-subscriptions-to-IPC-events-on-reload branch December 13, 2018 13:26
@evgenykochetkov evgenykochetkov mentioned this pull request Dec 26, 2018
Merged
This was referenced Dec 27, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

@knopki knopki Awaiting requested review from knopki

Assignees

@evgenykochetkov evgenykochetkov

Labels
s:client t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evgenykochetkov @nkrkv @brusherru