-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xod/core/select
description and add test patch
#1598
Conversation
I can’t suggest anything constructive straight away, but I’d like to note that the problem is deeper than the choice of where the test should reside. This is related to #888 as well. The problem is when we have a library opened as a project. At this time we effectively have the contents loaded twice. A poper solution should address the library development experience. But until we have no solution, a separate project |
2314c43
to
929db9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be under CI, but they are not currently:
test-cpp:
docker: *docker-custom-nodejs
environment:
XOD_OUTPUT: /tmp/tabtests-cpp
steps:
- checkout
- restore_cache: *restore-node_modules
- run: *step-install
- run:
name: Build CLI
command: yarn build:cli
- run:
name: Generate tabtests
command: | # --------------------- here
ls -d workspace/__lib__/xod/* | xargs -n 1 \
yarn xodc tabtest --no-build | cat
- run:
name: Build tabtests
command: make -C $XOD_OUTPUT
- run:
name: Run tabtests
command: make -C $XOD_OUTPUT test
Should be:
ls -d workspace/__lib__/xod/* workspace/test-core | xargs ...
And if so, would it better to put the test under a common subdirectory (workspace/test
?) to avoid touching the config in future?!
929db9e
to
c568c3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
c568c3c
to
c5816b1
Compare
But we have a problem to write such tests in the same library because tabtests will get an error:
So probably we have to extract such tests into separate
xod/test-core
? 🤔Also, in this case, will be no problems with position of defers in the program graph :)