New look of patch board with bound values #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenykochetkov
requested changes
Feb 13, 2019
There was a problem hiding this comment.
Looks awesome 👍🏻
But there are a few inconsistencies left:
because pins got smaller, they look off in the inspector
comment border did not change:
(is this because of #1380?)
lines to input pins in the suggester look off:
| @@ -3,6 +3,10 @@ | |||
| } | |||
|
|
|||
| #patch_bg_pattern { | |||
| g { | |||
| // Compensate bluring | |||
| const textVerticalOffset = PIN_RADIUS + TEXT_OFFSET_FROM_PIN_BORDER; | ||
| const isInput = direction === PIN_DIRECTION.INPUT; | ||
|
|
||
| const textProps = { | ||
| x: position.x, | ||
| y: position.y + textVerticalOffset * (isInput ? -1 : 1), | ||
| y: position.y - textVerticalOffset * (isInput ? -1 : 1), |
There was a problem hiding this comment.
Suggested change
| y: position.y - textVerticalOffset * (isInput ? -1 : 1), | |
| y: position.y + textVerticalOffset * (isInput ? 1 :- 1), |
|
Also, bound values are not shown in latest the Firefox and Chromium on macOS :( |
|
values bound to generic pins are not colored: |
brusherru
force-pushed
the
feat-1678-bound-values-on-patch-board
branch
from
fc13911
to
9bbccd7
Compare
|
All fixed and tweaked :)
|
nkrkv
requested changes
Feb 14, 2019
| * 3○ | ||
| * | ||
| * 2○ | ||
| * 1○ |
|
I think it’s a bit better to put node labels 2px higher: 10px top margin instead of 12px |
brusherru
force-pushed
the
feat-1678-bound-values-on-patch-board
branch
3 times, most recently
from
2a85486
to
ee2f778
Compare
brusherru
force-pushed
the
feat-1678-bound-values-on-patch-board
branch
from
ee2f778
to
3cf820c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #1678