Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tabline scrollable #1694

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Make tabline scrollable #1694

merged 4 commits into from
Feb 26, 2019

Conversation

evgenykochetkov
Copy link
Contributor

Closes #1087
Closes #414

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! The code is fine.

A few things I spotted that annoy a bit:

  1. If I open a new tab when the tabline is overflown already, I don’t see the newly activated tab. In particular, this would cause confusion when the debugger tab opens.
  2. If I click a tab which is half-hidden/half-visible, it “blinks.” It shows completely when the button is held down and disappears when the button is released. Looks like it is caused by drag-n-drop
  3. The < > arrows are misaligned vertically with tab contents

(1) and (2) can be solved by automatically scrolling to a tab being clicked or activated. By scrolling to I mean ensuring it is completely fit in the visible tabline area.

(3) Looks like a problem of tabs, not the buttons. Should we push tab contents up a couple of pixels?

Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 Bugs detected:

  1. I can't scroll any sidebar pane if I opened only one. (Show only ProjectBrowser and try to scroll it)
  2. The previous bug moves Deployment pane out of view area
  3. Even If I open Inspector and Help panes in the one sidebar, it moves Deployment pane and I can't see an entire Help pane content.

Here's a GIF with all these bugs:
bugs detected

@brusherru
Copy link
Contributor

brusherru commented Feb 20, 2019

🐛 One more bug:
When I open a new tab and tab panel scrolled to the active tab I see a native scrollbar 🙈
xod-bug2
And it reproduces with scrolling...

@brusherru
Copy link
Contributor

🐛
Also, padding over the tabs is disappearing right after IDE loads :)

@brusherru
Copy link
Contributor

Possibly, bug 🤷‍♂️

  1. Open a lot of tabs
  2. Scroll tabs to the left
  3. Scroll patch board
    Tab pane will scroll to the active one. Is it okay? :)

@brusherru
Copy link
Contributor

About design 🤓

  1. It's a little annoying when tabs scroll so fast (jumps) to the active one. Especially, if I click on the first item in the view area, which did not fit the container entirely.
    Maybe better to make a smooth scrolling? :)
  2. Button has a background color and sharp edges. So tabs that do not fit the container look ugly. What about adding a gradient or a slightly light stripe, or something else? 🤔

@evgenykochetkov evgenykochetkov force-pushed the fix-tabs-overflow-issues branch 3 times, most recently from 5a9632f to 4246659 Compare February 25, 2019 13:34
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎈

Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov merged commit 623435a into master Feb 26, 2019
@evgenykochetkov evgenykochetkov deleted the fix-tabs-overflow-issues branch February 26, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants