Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headings for tutorial’s first chapter #1743

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add headings for tutorial’s first chapter #1743

merged 1 commit into from
Apr 10, 2019

Conversation

evgenykochetkov
Copy link
Contributor

No description provided.

@evgenykochetkov evgenykochetkov self-assigned this Apr 8, 2019
nkrkv
nkrkv requested changes Apr 8, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, if we’re accepting change requests… here are my two cents 😊

The basic idea is moving any special formatting out of headings: they should be as simple as possible

workspace/welcome-to-xod/010-flip-flop/patch.xodp Outdated Show resolved Hide resolved
workspace/welcome-to-xod/011-if-else/patch.xodp Outdated Show resolved Hide resolved
@evgenykochetkov evgenykochetkov force-pushed the tweak-docs-add-headings-for-first-tutorial-chapter branch from 7001772 to 70dc555 Compare April 9, 2019 15:20
nkrkv
nkrkv approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov merged commit a474ffb into master Apr 10, 2019
@evgenykochetkov evgenykochetkov deleted the tweak-docs-add-headings-for-first-tutorial-chapter branch April 10, 2019 10:00
@evgenykochetkov evgenykochetkov mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
s:doc t:tweak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evgenykochetkov @nkrkv @brusherru