Patch noding section of the tutorial #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
previously requested changes
Apr 9, 2019
evgenykochetkov
force-pushed
the
feat-patching-section-for-tutorial
branch
from
a13f6f9
to
4f66fe5
Compare
nkrkv
changed the title
evgenykochetkov
force-pushed
the
feat-patching-section-for-tutorial
branch
2 times, most recently
from
bdf2582
to
0afb456
Compare
brusherru
requested changes
Apr 10, 2019
| { | ||
| "comments": [ | ||
| { | ||
| "content": "# Creating your own nodes\n\nIn this part of the tutorial, you will learn how to create your own XOD nodes.\n\nWe will take an existing patch, and *extract* a part of it into a separate node and add pins to control hard-coded parameters. Then we will add labels and descriptions that will be displayed in the help panel for our node, just like in XOD's standard library.", |
There was a problem hiding this comment.
Camel Cased H1 please in all these tutorials
| { | ||
| "comments": [ | ||
| { | ||
| "content": "# Next steps\n\nWhat you've just learned about making nodes is totally sufficient for day-to-day XODing.\n\nBut if you are interested in a more in-depth guide (for example, if you already have some expirience in Arduino programming), check out https://xod.io/docs/guide/#making-your-own-nodes. There you will learn about creating nodes in C++, testing them using tabtests and wrapping existing Arduino libraries.", |
| @@ -0,0 +1,43 @@ | |||
| { | |||
There was a problem hiding this comment.
Probably, we should tell somewhere in this tutorial about publishing library (but User should not publish this tutorial). What do you think? :)
| { | ||
| "comments": [ | ||
| { | ||
| "content": "# Congratulations!\n\nYou have completed the tutorial. Hope you enjoyed it. May we ask to rate it?\n\n[★★★★★ Excellent!](https://forum.xod.io/t/tutorial-feedback/457/?utm_source=ide&utm_medium=ide_comment&utm_campaign=tutorial_99&utm_term=5_stars)\n[★★★★ Very Good](https://forum.xod.io/t/tutorial-feedback/457/?utm_source=ide&utm_medium=ide_comment&utm_campaign=tutorial_99&utm_term=4_stars)\n[★★★ Okay](https://forum.xod.io/t/tutorial-feedback/457/?utm_source=ide&utm_medium=ide_comment&utm_campaign=tutorial_99&utm_term=3_stars)\n[★★ So-so](https://forum.xod.io/t/tutorial-feedback/457/?utm_source=ide&utm_medium=ide_comment&utm_campaign=tutorial_99&utm_term=2_stars)\n[★ Poor](https://forum.xod.io/t/tutorial-feedback/457/?utm_source=ide&utm_medium=ide_comment&utm_campaign=tutorial_99&utm_term=1_star)\n\nIf you would like to give more detailed feedback, we’ll happy to hear it on the rating page.", |
There was a problem hiding this comment.
Probably, we have to start the new topic to collect comments related only to the new tutorial? 🤔
evgenykochetkov
force-pushed
the
feat-patching-section-for-tutorial
branch
from
0afb456
to
e6a2415
Compare
evgenykochetkov
force-pushed
the
feat-patching-section-for-tutorial
branch
from
f38656c
to
1429ef2
Compare
brusherru
approved these changes
Apr 11, 2019
knopki
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.