Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++ errors/warnings in new nodes #1759

Merged
merged 2 commits into from Apr 17, 2019
Merged

Fix C++ errors/warnings in new nodes #1759

merged 2 commits into from Apr 17, 2019
+2 −2

Conversation

evgenykochetkov
Copy link
Contributor

Introduced in #1748.
Causes errors when compiling for esp8266 and some other platforms.

@evgenykochetkov evgenykochetkov self-assigned this Apr 17, 2019
nkrkv
nkrkv approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@evgenykochetkov evgenykochetkov removed the request for review from gabbapeople April 17, 2019 11:33
@evgenykochetkov evgenykochetkov merged commit 76d0b71 into master Apr 17, 2019
@evgenykochetkov evgenykochetkov deleted the fix-stdlib-cpp-errors-in-new-nodes branch April 17, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
regression s:stdlib t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evgenykochetkov @nkrkv @brusherru