Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add =XOD_PROJECT literal #1889

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Add =XOD_PROJECT literal #1889

merged 4 commits into from
Oct 23, 2019

Conversation

brusherru
Copy link
Contributor

It closes #1886

@brusherru brusherru self-assigned this Oct 17, 2019
@brusherru brusherru force-pushed the feat-1882-username-literal branch 2 times, most recently from 1830bc8 to 1f946c8 Compare October 17, 2019 15:00
@brusherru brusherru force-pushed the feat-1882-username-literal branch 3 times, most recently from 48f8559 to 96f70b0 Compare October 18, 2019 10:19
@brusherru brusherru changed the base branch from feat-1882-username-literal to master October 18, 2019 13:27
@brusherru
Copy link
Contributor Author

@nkrkv @evgenykochetkov check it out, please

nkrkv
nkrkv approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nkrkv
nkrkv requested changes Oct 18, 2019
View reviewed changes
packages/xod-arduino/src/messages.js Show resolved Hide resolved
packages/xod-arduino/src/messages.js Outdated Show resolved Hide resolved
packages/xod-arduino/src/messages.js Outdated Show resolved Hide resolved
packages/xod-arduino/src/transpiler.js Outdated Show resolved Hide resolved
@brusherru brusherru requested a review from nkrkv October 22, 2019 12:05
nkrkv
nkrkv requested changes Oct 22, 2019
View reviewed changes
packages/xod-arduino/platform/configuration.tpl.cpp Outdated Show resolved Hide resolved
packages/xod-arduino/src/messages.js Outdated Show resolved Hide resolved
@brusherru brusherru requested a review from nkrkv October 22, 2019 13:03
@nkrkv nkrkv mentioned this pull request Oct 22, 2019
Closed
nkrkv
nkrkv requested changes Oct 22, 2019
View reviewed changes
packages/xod-arduino/src/transpiler.js Outdated Show resolved Hide resolved
packages/xod-arduino/src/transpiler.js Outdated Show resolved Hide resolved
packages/xod-arduino/src/types.js Outdated Show resolved Hide resolved
@brusherru brusherru force-pushed the feat-1886-project-literal branch 2 times, most recently from 808b1d1 to fe54153 Compare October 22, 2019 17:08
@brusherru brusherru requested a review from nkrkv October 22, 2019 17:09
@brusherru
fix(xod-arduino, xod-client): move the check for literal values and e…
5225df9 
…rror messages from `xod-client` to `xod-arduino` and avoid excessive errors about username and project name when these literals is not used in the project
@brusherru
refactor(xod-arduino): rename variable names like literals into a p…
8c9acd2 
…roper `globals`
@brusherru brusherru requested a review from nkrkv October 23, 2019 10:21
nkrkv
nkrkv approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brusherru brusherru merged commit 7d5e367 into master Oct 23, 2019
@brusherru brusherru deleted the feat-1886-project-literal branch October 23, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov Awaiting requested review from evgenykochetkov

Assignees

@brusherru brusherru

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brusherru @nkrkv