Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for amqplib connection unhappy path timeout #65

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

lamchakchan
Copy link
Contributor

Description

  • For both the createConnection and createChannel logic, the unhappy path when the amqplib returns with err populated, the semaphore counter for the respective resource was not reset causing future connection and channel resolutions to hang.
  • When a channnel + queue is consumed and the queue is being deleted, a null payload is send down the consume RPC call. Logic needed to be put in place to account for null payloads to not act.
  • Also adjusted the test name.

Related Issue

Motivation and Context

Fix all them bugs!

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lamchakchan lamchakchan self-assigned this Mar 14, 2017
@lamchakchan lamchakchan added this to the 2.1.2 milestone Mar 14, 2017
@lamchakchan lamchakchan removed the request for review from WesTyler March 14, 2017 20:03
@lamchakchan lamchakchan merged commit 6e3f3ab into xogroup:master Mar 14, 2017
@lamchakchan lamchakchan deleted the bad-configuration-settings branch March 14, 2017 20:04
Copy link
Member

@WesTyler WesTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lamchakchan

], (err) => {

if (err) {
$._state.connectionSemaphore = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh, I see. Nice catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always the simple things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants