Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAll interface #67

Merged
merged 2 commits into from
Apr 25, 2017

Conversation

lamchakchan
Copy link
Contributor

Description

Added a getAll interface to address accessibility around ease of being able to pump all messages off of a queue.

Related Issue

Motivation and Context

The use of subscribe is not sufficient for use cases when the need for a vanilla data pump is necessary. Cases where we only want to listen for messages off of a queue and do not want to associate any routeKey mapping.

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lamchakchan lamchakchan added this to the 2.2.0 milestone Apr 25, 2017
@lamchakchan lamchakchan merged commit 4eeb588 into xogroup:master Apr 25, 2017
@lamchakchan lamchakchan deleted the 66-error-queue-subscriptions branch April 25, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant