Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature to override subscribe safe guards and fixed minor bugs #72

Merged

Conversation

lamchakchan
Copy link
Contributor

Description

Added two flags validatePublisher and validateVersion to allow for overriding of safe guards within the subscriber end to skip checking of publisher signature and matching major version of publishing agent.

Also found a bug within Helpers.cleanObject() function where it was unintentionally wiping properties with values set to false because of truthy check. Replaced this with a more rigorous type check against undefined and null.

Updated one of the test in the callback suite to a callback structure from a Promise based structure to align with the intent of the test file.

A timeout bug was found through one of the edge case automation test where a connection made to a non-existent server took too long (60s >) to time out. Timeout code wrapper around the connection logic has been added to provide for shorter timeout periods.

Related Issue

Motivation and Context

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lamchakchan lamchakchan merged commit 0e3098a into xogroup:master Sep 28, 2017
@lamchakchan lamchakchan deleted the 68-add-options-for-header-check branch September 28, 2017 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant