added feature to override subscribe safe guards and fixed minor bugs #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two flags
validatePublisher
andvalidateVersion
to allow for overriding of safe guards within the subscriber end to skip checking of publisher signature and matching major version of publishing agent.Also found a bug within
Helpers.cleanObject()
function where it was unintentionally wiping properties with values set tofalse
because of truthy check. Replaced this with a more rigorous type check againstundefined
andnull
.Updated one of the test in the callback suite to a callback structure from a Promise based structure to align with the intent of the test file.
A timeout bug was found through one of the edge case automation test where a connection made to a non-existent server took too long (60s >) to time out. Timeout code wrapper around the connection logic has been added to provide for shorter timeout periods.
Related Issue
Motivation and Context
Types of changes
lib/
ortest/
files)Checklist: