Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the bug around wildcards and RMQ subscriptions. The initial implementations allowed for wild cards (
#
,*
) to be used against theconsume
interface of RMQ. But when messages were sent back down stream tobunnyBus
, the routes did not match the routes used with the handlers set in the subscription call because logic was not implemented to do any wild card substitutions. To support this, pattern matching logic had to be written around dynamicregex
generation. A lot of test were put in place to prove the rigor of the runtime for this bug fix.Related Issue
Motivation and Context
While no messages were ever lost when a message was subscribed down and missed by the handler because by default,
bunnyBus
forwards all messages with processing issues to the error queue; we do want to make sure the subscriber runs in parity with the route key binding language of RMQ.Types of changes
lib/
ortest/
files)Checklist: