Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62 consumer route pattern matching #74

Merged

Conversation

lamchakchan
Copy link
Contributor

Description

Fixed the bug around wildcards and RMQ subscriptions. The initial implementations allowed for wild cards (#, *) to be used against the consume interface of RMQ. But when messages were sent back down stream to bunnyBus, the routes did not match the routes used with the handlers set in the subscription call because logic was not implemented to do any wild card substitutions. To support this, pattern matching logic had to be written around dynamic regex generation. A lot of test were put in place to prove the rigor of the runtime for this bug fix.

Related Issue

Motivation and Context

While no messages were ever lost when a message was subscribed down and missed by the handler because by default, bunnyBus forwards all messages with processing issues to the error queue; we do want to make sure the subscriber runs in parity with the route key binding language of RMQ.

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lamchakchan lamchakchan added this to the 2.3.0 milestone Sep 30, 2017
@lamchakchan lamchakchan merged commit a138d2d into xogroup:master Sep 30, 2017
@lamchakchan lamchakchan deleted the 62-consumer-route-pattern-matching branch September 30, 2017 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants