Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored public interface to only include promisification and moved… #77

Merged
merged 2 commits into from
Mar 3, 2018

Conversation

lamchakchan
Copy link
Contributor

… actual processing to private functions

Description

Refactored all public functions with dual callback and promise interface to now only execute once.

Related Issue

Motivation and Context

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lamchakchan lamchakchan added the bug label Mar 3, 2018
@lamchakchan lamchakchan merged commit 504edd2 into xogroup:master Mar 3, 2018
@lamchakchan lamchakchan deleted the sinon-spy-count-fix branch March 3, 2018 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant