Add support for other extensions

[OmgImAlexis]

Right now the cli works fine with plugins and extensions. When adding for example the vue plugin I've updated my package.json with this and xo finds the issues. Yet when I open Atom I get no linter issues showing up at all.

        "plugins": [
            "vue"
        ],
        "extensions": [
            "vue"
        ]

I'm guessing this is what's causing the issue.

const SUPPORTED_SCOPES = [
	'source.js',
	'source.jsx',
	'source.js.jsx',
	'source.js.embedded.html'
];

---

IssueHunt Summary

Sponsors (Total: $40.00)

• issuehunt ($40.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[sindresorhus]

Correct. I think we need a mapping between known file extensions and Atom scopes, and then check whether the user added any of the supported scopes from the "extensions" option and then add it to SUPPORTED_SCOPES. Could also take a look at how for example atom-linter-eslint solves this.

[marionebl]

If I unterstand linter-eslint/src/main.js#L75 correctly this is delegated to user configuration completely?

[Arcanemagus]

@marionebl Correct, the list of scopes that linter-eslint tells linter it should run on is determined entirely from the user config since we have no way of knowing all the possibilities that are out there with ESLint processors.

The known supported scripts are set as the default in the settings, users can add more if they want.

You can also find an alternative approach in use for the lintHtmlFiles setting: If that setting is enabled we add the embedded HTML scope to the current list (whatever it may be), and remove it on disabling of the setting. (here)

Hope that helps!

[IssueHuntBot]

@issuehunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[sindresorhus]

Closing as Atom is abandoned.