Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react/jsx-first-prop-new-line rule #24

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Add react/jsx-first-prop-new-line rule #24

merged 1 commit into from
Jan 8, 2020

Conversation

fregante
Copy link
Member

@fregante fregante commented Jan 8, 2020

This is currently allowed:

<tag attr1
	attr2
/>

With this rule, it will be fixed to:

<tag
	attr1
	attr2
/>

or you can use:

<tag attr1 attr2/>

More info on https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-first-prop-new-line.md

The default multiline-multiprop makes the most sense to me because it disallows

<tag
	onlyOneAttr
/>

fregante added a commit to refined-github/refined-github that referenced this pull request Jan 8, 2020
@sindresorhus sindresorhus changed the title Enable react/jsx-first-prop-new-line Add react/jsx-first-prop-new-line rule Jan 8, 2020
@sindresorhus sindresorhus merged commit 06fa860 into xojs:master Jan 8, 2020
@fregante fregante deleted the patch-1 branch January 8, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants