Add @typescript-eslint/no-redeclare rule
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 025fcf4 said that no-redeclare has been fixed and removed 'no-redeclare': 'off'. But we still need the typescript-eslint version of this rule, not the base rule. For example, the base rule doesn’t support overloads: export function f(x: number): number; export function f(x: string): string; export function f(x: number | string): number | string { return x; } test.ts:2:17 ✖ 2:17 f is already defined. no-redeclare ✖ 3:17 f is already defined. no-redeclare 2 errors Signed-off-by: Anders Kaseorg <andersk@mit.edu>
sindresorhus
changed the title
@typescript-eslint/no-redeclare rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 025fcf4 said that
no-redeclarehas been fixed and removed'no-redeclare': 'off'. But we still need the typescript-eslint version of this rule, not the base rule. For example, the base rule doesn’t support overloads: