Allow pascal-case in .tsx files
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of copying, can you extract the whole object to a function at the top-level that returns it when called, and then use it in both, but modify it in the |
sindresorhus
changed the title
tsx.tsx files
younho9
deleted the
feat/override-typescript-eslint-naming-convention-in-tsx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added override of
@typescript-eslint/naming-conventionrule for the tsx file.When the rule was overridden, the internal options are not merged, so I just copied above rule.
I considered the detailed choices to allow the PascalCase for a while, but the component function could be used anywhere, I just added StrictPascalCase to origin rule.
If there is another opinion, I will reflect it in the PR.
resolve #48