Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set properties: never in the camelCase rule #44

Closed
wants to merge 1 commit into from
Closed

Conversation

j-f1
Copy link

@j-f1 j-f1 commented Dec 29, 2017

Fixes xojs/xo#225.

@pvdlg
Copy link
Contributor

pvdlg commented Jan 7, 2018

#43 has already been refused.

The issue xojs/xo#225 is about ESLint no being able to handle interaction between the quote-props and the camelcase rules.

The desired behavior is the force using quote on non camel case prop, force using camel case prop, but allow to use non camel case prop when they are quoted.

This would work like this:

  • {snake_case: 'value'} => error, should use camel case
  • {'camelCase': 'value'} => error, should use not quote properties
  • {'snake_case': 'value'} => valid

@j-f1
Copy link
Author

j-f1 commented Jan 7, 2018

The fact that { 'foo_bar': baz } is allowed by camelcase is a bug.

@sindresorhus
Copy link
Member

Closing as this is not the correct fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants