Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -moz-tab-size #10

Merged
merged 2 commits into from
May 9, 2020
Merged

Allow -moz-tab-size #10

merged 2 commits into from
May 9, 2020

Conversation

fregante
Copy link
Member

@fregante fregante commented May 8, 2020

I'm not sure of what's the logic for allowing properties here, but how about -moz-tab-size?

Prefix-less tab-size is still not allowed in Firefox.

@sindresorhus
Copy link
Member

sindresorhus commented May 9, 2020

It's already defined here:

'tab-size' // It's still only prefixed in Firefox

@fregante
Copy link
Member Author

fregante commented May 9, 2020

value-no-vendor-prefix is not what's triggering this error:

https://github.com/sindresorhus/refined-github/runs/658808320#step:4:10

source/refined-github.css
 16:2  ✖  Unexpected vendor-prefix "-moz-tab-size"   property-no-vendor-prefix

I think value-no-vendor-prefix allows display: -moz-flex while property-no-vendor-prefix allows -moz-tab-size: 2

@sindresorhus
Copy link
Member

You're right. Can you remove that previous tab-size entry then? Since it's in the wrong place.

@sindresorhus sindresorhus merged commit df2b76a into xojs:master May 9, 2020
@fregante fregante deleted the patch-2 branch May 9, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants