Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring towards webpack #143

Closed
wmertens opened this issue Sep 14, 2016 · 6 comments · Fixed by #375
Closed

Allow configuring towards webpack #143

wmertens opened this issue Sep 14, 2016 · 6 comments · Fixed by #375
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@wmertens
Copy link
Contributor

wmertens commented Sep 14, 2016

Issuehunt badges

I think that instead of installing the webpack importer plugin manually and setting up the importer resolver (provided that starts working after #142), it would be more in the spirit of XO to simply define webpack: true or webpack: "config-file-name.js".


IssueHunt Summary

dflupu dflupu has been rewarded.

Backers (Total: $60.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Member

Wonder if we can just detect a webpack.config.js file and enable the webpack resolver automagically.

@wmertens
Copy link
Contributor Author

Not all projects will have one named like that, but indeed it's a nice
start, and then being able to override manually…

On Sun, Oct 23, 2016, 1:34 AM Sindre Sorhus notifications@github.com
wrote:

Wonder if we can just detect a webpack.config.js file and enable the
webpack resolver automagically.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#143 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlgTfiyVU3AtsB2wyoDItdN3Y8bfKks5q2p10gaJpZM4J8xX9
.

@IssueHuntBot
Copy link

@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt

@dflupu
Copy link
Contributor

dflupu commented Jan 27, 2019

@sindresorhus

Was looking to submit a PR. Should I add a setting as well, or just make xo detect the config?

@sindresorhus
Copy link
Member

Use webpack.config.js if it exists, otherwise the user needs to set a path to the webpack config file using an option called webpack.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Mar 11, 2020

@sindresorhus has rewarded $54.00 to @dflupu. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $6.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants