Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tap-snapshots/** to default ignores #384

Closed
coreyfarrell opened this issue May 20, 2019 · 1 comment · Fixed by #385
Closed

Add tap-snapshots/** to default ignores #384

coreyfarrell opened this issue May 20, 2019 · 1 comment · Fixed by #385

Comments

@coreyfarrell
Copy link
Contributor

Would you accept a patch adding tap-snapshots/*.js to the default ignores? These files are generated/used by tapjs. I set the xo.ignores option in package.json in a project using tap snapshots but hope this scenario can be supported with zero config.
@sindresorhus
Copy link
Member

Sure. My general rule for adding default ignores is that it has to be helpful for a lot of users and that it's unambiguous.

coreyfarrell added a commit to coreyfarrell/xo that referenced this issue May 21, 2019
@coreyfarrell
Add tap-snapshots/*.js to default ignore list
4a68c82 
Fixes xojs#384
@coreyfarrell coreyfarrell mentioned this issue May 21, 2019
Merged
sindresorhus pushed a commit that referenced this issue May 29, 2019
@coreyfarrell @sindresorhus
Add tap-snapshots/*.js to default ignore list (#385)
b73b11b 
Fixes #384
coreyfarrell added a commit to coreyfarrell/xo that referenced this issue Apr 10, 2020
@coreyfarrell
Add tap-snapshots/*.cjs to default ignore list
ccdf0a2 
The next version of tap will be using the `.cjs` extension to for
compatibility with packages that have `"type": "module"`.

Ref xojs#384
coreyfarrell added a commit to coreyfarrell/xo that referenced this issue Apr 10, 2020
@coreyfarrell
Add tap-snapshots/*.cjs to default ignore list
6887f3d 
The next version of tap will be using the `.cjs` extension for
compatibility with packages that have `"type": "module"`.

Ref xojs#384
@coreyfarrell coreyfarrell mentioned this issue Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tap-snapshots/*.js to default ignore list coreyfarrell/xo
3 participants
@sindresorhus @coreyfarrell and others