Allow to override default ignore with negative patterns #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65
In
lintFiles
instead of passing the ignores to globbyignores
options, this PR invert the ignores patterns and pass them to globby within the pattern array.The ignores pattern from the
ignores
options are concatenated to the default one so they can override them.We have to invert the ignores patterns and pass them to the
pattern
parameter because node glob doesn't handle opposed patterns in theignore
options. In other words passing['dir/**', '!dir/**']
or['dir/**']
in theignore
options exclude the files indir
in both case. But passing['!dir/**', 'dir/**']
in thepattern
argument does include the files indir
.