Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix unit tests #344

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Update dependencies and fix unit tests #344

merged 2 commits into from
Jul 24, 2018

Conversation

pvdlg
Copy link
Contributor

@pvdlg pvdlg commented Jul 24, 2018

No description provided.

Add a filename to help Prettier figure the file type as the test content is too minimal
@pvdlg
Copy link
Contributor Author

pvdlg commented Jul 24, 2018

Travis seems to be fixed 🎉

@sindresorhus sindresorhus merged commit e783704 into master Jul 24, 2018
@sindresorhus
Copy link
Member

Yay!

@graingert
Copy link

@sindresorhus @pvdlg can you make a release of this please?

@sindresorhus
Copy link
Member

@antonmedv
Copy link

Installed xo:

"devDependencies": {
    "xo": "^0.22.0"
  }

But still got ✖ Parsing error: Cannot read property ecmaFeatures of undefined.
Fresh CRA and XO.

@antonmedv
Copy link

npm ls eslint-plugin-node
***
└─┬ xo@0.22.0
  └── eslint-plugin-node@7.0.1

@vinkla
Copy link

vinkla commented Sep 19, 2018

I'm also having the same issue as @antonmedv with version ^0.23.0 and create-react-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants