Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in project description that XO is an ESLint wrapper #528

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Mention in project description that XO is an ESLint wrapper #528

merged 2 commits into from
Apr 2, 2021

Conversation

darkred
Copy link
Contributor

@darkred darkred commented Apr 2, 2021

With this PR I change the description in readme.md(1st phrase) and in package.json, from:
JavaScript/TypeScript linter with great defaults to:
JavaScript/TypeScript linter (ESLint wrapper) with great defaults
in order to better clarify/stand out that xo uses ESLint underneath, an already very popular and widely used JavaScript linter,
and that it's not a linter itself, like JSLint, JSHint, ESLint, etc,
something that might discourage a new user from trying it, if he sees it for the first time, and has never heard of it.

Currently, searching in GitHub and npmjs,
the description, as it is, and the tags used in npmjs,
might all give the wrong impression that it's the opposite:

screenshots:

GitHub search

2021-04-02_155655

npmjs dropdown

2021-04-02_160311

npmjs search

2021-04-02_155952

 
Thank you

@darkred darkred changed the title Add in the description that xo is an ESLint wrapper Add in description that xo is an ESLint wrapper Apr 2, 2021
@sindresorhus sindresorhus changed the title Add in description that xo is an ESLint wrapper Add in description that Xo is an ESLint wrapper Apr 2, 2021
@sindresorhus sindresorhus changed the title Add in description that Xo is an ESLint wrapper Mention in project description that XO is an ESLint wrapper Apr 2, 2021
@sindresorhus sindresorhus merged commit c886ce5 into xojs:main Apr 2, 2021
@sindresorhus
Copy link
Member

Good point 👍

@darkred
Copy link
Contributor Author

darkred commented Apr 2, 2021

Thank you for the merge and your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants