isatty should force usage of the colored formatter #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some terminals (like travis and jupyter) can not have colored output, because the terminal is checked again with
humanfriendly.terminal_supports_colors(stream)
this leads to no coloured output on travis and jupyter.
the 'isatty' keyword is triadic :
at the Moment You treat
isatty = True
the same way like it would beNone
- butisatty=True
should force the use of theColoredFormatter
!If You dont like it for a reason, You also can put a new keyword like
force_color
but from my point of view it should not be neccessary.However, with that patch the colored output is possible now for Jupyter (on stdout) and Travis (on stderr) !
please consider it, until then I need to host my own fork on pypi to get the wheels ....
yours sincerely
Robert